forked from freebsd/freebsd-ports
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devel/llvm-morello-c18n: add based on devel/llvm-morello #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwitaszczyk
reviewed
Feb 20, 2025
kwitaszczyk
reviewed
Feb 20, 2025
There are more changes required to allow the installation of llvm-morello and llvm-morello-c18n at the same time:
|
2654cff
to
c04f001
Compare
Add a port of John's lld development branch with early policy support.
I'd misunderstood the case where --start/end-no-unused-arguments were needed in my previous commit. Add a comment with the correct explanation which is not future proofing, but instead that some invocations of the compiler (e.g., clang -v) don't end up consuming the -Xclang arguments. Reported by: jrtc27 Fixes: 1cf8031 devel/llvm-{cheri,morello}: future-proof ABI arguments (cherry picked from commit 283c8d9)
FreeBSD's base llvm currently makes -Wimplicit-int and -Wimplicit-function-declaration not produce errors by default (see c3450ad127e94d3fa67ae337310e59c002f51bfc) which means a chunk of the ports collection depends on this behavior. Until this is resolve we need to mirror that behavior on CheriBSD. Sponsored by: DARPA, AFRL (cherry picked from commit 91f85b5)
c04f001
to
34dbc51
Compare
Thanks @kwitaszczyk, I believe I've applied those changes. |
kwitaszczyk
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brooksdavis Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a port of John's lld development branch. This version does not support the policy file, only the --compartment argument.